Add handin-make-page to tweak the rendered server pages#48
Open
elibarzilay wants to merge 2 commits intoracket:masterfrom
Open
Add handin-make-page to tweak the rendered server pages#48elibarzilay wants to merge 2 commits intoracket:masterfrom
handin-make-page to tweak the rendered server pages#48elibarzilay wants to merge 2 commits intoracket:masterfrom
Conversation
The default works as it did, so no changes to that --- *except* for the fact that this uses `xexpr->string` which is very fast compared to the previous. Given that the style is done through CSS, parameterizing that could go a long way, but in some cases (as is in mine), there's additional navbar content, and additional JS scripting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default works as it did, so no changes to that --- except for the
fact that this uses
xexpr->stringwhich is very fast compared to theprevious.
Given that the style is done through CSS, parameterizing that could go a
long way, but in some cases (as is in mine), there's additional navbar
content, and additional JS scripting.