Skip to content

fix popup-menu's result and clarify the docs a little #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rfindler merged 1 commit into from
Jan 5, 2026
Merged

fix popup-menu's result and clarify the docs a little #362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions gui-doc/scribblings/gui/editor-admin-class.scrbl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,8 +189,9 @@ Does nothing.

@popupmenuinfo[@elem{administrator's @techlink{display}}
@elem{top-level editor in this administrator's @techlink{display}}
@elem{The result is @racket[#t] if the popup succeeds,
@racket[#f] otherwise (independent of whether the
@elem{The result is @racket[#f] if this admin is not connected to
a canvas or the canvas it is connected to does not have an editor,
@racket[#t] otherwise (independent of whether the
user selects an item in the popup menu).}]

The menu is displayed at @racket[x] and @racket[y] in editor coordinates.
Expand Down
3 changes: 2 additions & 1 deletion gui-lib/mred/private/wxme/editor-canvas.rkt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1345,7 +1345,8 @@
(let-boxes ([dx 0.0]
[dy 0.0])
(send canvas get-dc-and-offset dx dy)
(send canvas popup-menu m (->long (- x dx)) (->long (- y dy)))))))))
(send canvas popup-menu m (->long (- x dx)) (->long (- y dy)))
#t))))))

(define/public (adjust-std-flag)
;; 1 indicates that this is the sole, main admin.
Expand Down
Loading