Prometheus formatting support + refactor#15
Merged
mkuratczyk merged 12 commits intomainfrom Jul 18, 2025
Merged
Conversation
* add new/4 which allows attaching labels to counters * add format/2 to only formal a subset of metrics * add prom_format/2,3 to return a Prometheues exposition format binary Refactors including: * renaming arguments for consistency * adding specs * adding edocs * eunit -> CT * erlang.mk update
mkuratczyk
force-pushed
the
prometheus-support
branch
from
94dbf1d to
675c680
Compare
Additionally, store the rendered labels as a bitstring, to avoid converting a map to a bitstring on every scrape. This gives ~30% scrape speed-up with a large number of metrics.
mkuratczyk
force-pushed
the
prometheus-support
branch
from
270dfed to
2c0f458
Compare
mkuratczyk
force-pushed
the
prometheus-support
branch
2 times, most recently
from
cab7ec5 to
080e94e
Compare
eunit_formatters no longer needed
mkuratczyk
force-pushed
the
prometheus-support
branch
from
080e94e to
979d83c
Compare
* more consistent naming * better formatting * different order of things
mkuratczyk
force-pushed
the
prometheus-support
branch
from
253e9ae to
aec4c4e
Compare
kjnilsson
requested changes
Jun 5, 2025
Contributor
kjnilsson
left a comment
kjnilsson
left a comment
There was a problem hiding this comment.
Looks good, a few formatting comments + an API change to consider.
mkuratczyk
force-pushed
the
prometheus-support
branch
from
8f8cdb7 to
49ae049
Compare
kjnilsson
approved these changes
Jul 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors including: