Open
Conversation
MarcialRosales
force-pushed
the
stream_offset_landmarks
branch
from
f73a0d6 to
9fa9c3f
Compare
MarcialRosales
force-pushed
the
stream_offset_landmarks
branch
from
16a9737 to
56d9665
Compare
- Reuse existing scaning functions - Specify -via argments- the exact offset percentiles (between 0.0 and 1.0). - Use samples rather than landmarks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds stream_offset_landmarks/1 function to the osiris_log module, which scans the log index and returns first, last, and percentile landmarks (25%, 50%, 75%) as {offset(), timestamp()}.
Used by the stream browser to render an offset bar with offset and timestamp at each landmark. The user can attach to a stream by dragging the control in the bar to the offsets they wish. Having landmarks helps the user jump to a specific offset or timestamp.
Maybe the function can be more generic and accept other kinds of percentiles and not just 25, 50 and 75.