-
Notifications
You must be signed in to change notification settings - Fork 30
Dynamic citations, support for JSON-stat2, fix tests #280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi! This sounds like great fixes and additions. However, the tests are failing. Please check the unit tests what might be wrong. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #280 +/- ##
==========================================
- Coverage 89.80% 89.72% -0.09%
==========================================
Files 32 32
Lines 1825 1829 +4
==========================================
+ Hits 1639 1641 +2
- Misses 186 188 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@MansMeg tests are now fixed, everything should be ok. I also bumped the patch version up by a notch |
|
Test remaining failures seem to be of the type "Error in |
MansMeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent!
Changes made to CITATION in a nutshell:
Changes made to pxweb_get in a nutshell:
Changes made to tests in a nutshell:
I noticed, while intending to cite pxweb in a publication, that the citation, or more specifically the citation("pxweb") for pxweb CRAN release 0.17.0 was inadvertently out of date. I changed the CITATION file so that it now automatically updates the year and version number of the package in the citation. I also removed the textVersion field since it is easily forgotten and becomes out-of-date as well. Without the textVersion field the citation() function outputs a normal text citation
I have also noticed some time ago that json-query files, or at least those downloaded from StatFin website, have an additional queryObj -layer that however is easily removed, making it compatible with the type of json query that can be copy-pasted from the website. I figured it's easy enough a fix to warrant its inclusion in the package
Fixes to tests that were failing, see #279