Merged
Conversation
Problem: The code written in this project should be concise regardless of who is contributing. Solution: Add spotless to ensure one style of formatting for Java, JSON and Markdown files.
Problem: Code formatting must be applied manually. This does not ensure that newly committed code follows the wanted code style. Solution: Add local git hook that runs before the code is pushed and formats it on-the-fly using spotless and its configuration in the pom.xml.
Problem: The current code is not formatted. Every change on files will bring in additional formatting changes which produce noise when checking the commit changes. Solution: Apply one commit that applies the proper formatting on all files: java, json, md
Problem: The CONTRIBUTING.md file has currently a wrong name. Solution: Rename the file to have the recommended name CONTRIBUTING.md
Problem: Currently wildcard imports in java classes are possible. But we do not want to have them. Solution: Use checkstyle to detect wildcard import and let the build fail if they are present.
Problem: JUnit 6.0.0 has finally been released and should be used in this repository. Solution: Update dependency version to 6.0.0.
Feature/support junit 6
Owner
Author
|
Merge latest changes upwards from 6.x branch into develop branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.