Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/hooks/useNaverMapInit/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { useIsomorphicLayoutEffect } from "../useIsomorphicLayoutEffect";
import { SCRIPT_ID } from "./constants";
import type { InitResult, UseNaverMapInit } from "./types";
import {
createNaverMapScriptByClientId,
createNaverMapScriptByKeyId,
insertNaverMapScriptIntoHead,
} from "./utils";

Expand All @@ -17,7 +17,7 @@ import {
* @param onError - This function will triggered when loading script failed. If 'onError' changes too often, wrap that definition in useCallback
*/
export const useNaverMapInit: UseNaverMapInit = ({
ncpClientId,
ncpKeyId,
submodules,
onLoad,
onError,
Expand All @@ -39,8 +39,8 @@ export const useNaverMapInit: UseNaverMapInit = ({

const initNaverMapScript = async () => {
const scriptInitResult = new Promise<InitResult>((resolve, reject) => {
const script = createNaverMapScriptByClientId({
ncpClientId,
const script = createNaverMapScriptByKeyId({
ncpKeyId: ncpKeyId,
submodules,
});
insertNaverMapScriptIntoHead(script);
Expand All @@ -62,7 +62,7 @@ export const useNaverMapInit: UseNaverMapInit = ({
};

initNaverMapScript();
}, [ncpClientId]);
}, [ncpKeyId]);

useIsomorphicLayoutEffect(() => {
if (onLoad && isFunction(onLoad) && isLoaded) {
Expand Down
2 changes: 1 addition & 1 deletion src/hooks/useNaverMapInit/types.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
export interface InitParams {
ncpClientId: string;
ncpKeyId: string;
submodules?: Submodule[]
onLoad?: VoidFunction;
onError?: VoidFunction;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import { SCRIPT_ID } from "../constants";
import type { InitParams } from "../types";

export const createNaverMapScriptByClientId = ({
ncpClientId,
export const createNaverMapScriptByKeyId = ({
ncpKeyId,
submodules,
}: Pick<InitParams, "ncpClientId" | "submodules">) => {
}: Pick<InitParams, "ncpKeyId" | "submodules">) => {
const script = document.createElement("script");
let paramsString = `ncpClientId=${ncpClientId}`;
let paramsString = `ncpKeyId=${ncpKeyId}`;

if (submodules?.length) {
paramsString = paramsString.concat(`&submodules=${submodules.join(",")}`);
Expand Down
2 changes: 1 addition & 1 deletion src/hooks/useNaverMapInit/utils/index.ts
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
export * from "./createNaverMapScriptByClientId";
export * from "./createNaverMapScriptByKeyId";
export * from "./insertNaverMapScriptIntoHead";