Remote Code Execution via /login endpoint - Critical #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses a critical Remote Code Execution (RCE) vulnerability in the
/loginendpoint. Previously, a GET request to/loginprocessed user-supplied input viarequest.json['backdoor']and executed it usingsubprocess.runwithbash -c, allowing attackers to execute arbitrary shell commands on the server.fix
The vulnerable code accepting and executing the
backdoorparameter viasubprocess.runhas been removed. The/loginendpoint for GET requests now simply returns a JSON error message with a 404 status, eliminating any code execution path. This closes the RCE vector and ensures that the endpoint is not exploitable by crafted GET requests.author info
Patch provided by the Application Security Engineering team. Please contact
appsec-team@example.comfor any questions.