-
-
Notifications
You must be signed in to change notification settings - Fork 23
Interactive documentation with klipse #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@viebel Should this work already? I get the following warnings in my browser: |
|
It used to work yesterday when I upgraded klipse to cljs 1.9.293. On Fri, 4 Nov 2016 at 14:11 r0man notifications@github.com wrote:
|
|
ok On Fri, Nov 4, 2016 at 1:22 PM, Yehonathan Sharvit <notifications@github.com
|
|
I have deployed a new version of KLIPSE with cljs 1.9.293. It should be fine now. I noticed that the tests failed. Any idea why? |
|
@viebel The tests fail because you commented out |
|
So we should fix the test and include On Wed, 9 Nov 2016 at 17:07 r0man notifications@github.com wrote:
|
|
@viebel I tried the latest version and it seems to work. I also noticed some minor issues:
Given those points above I am not sure I want to switch the documentation at the moment. I am a bit busy with other things at the moment, so making the documentation pretty isn't very important for me at the moment. |
|
I have mode some progress and now the sqlingvo namespaces are cached and the cache is retrieved by klipse when the code is evaluated. I think it makes the UX much more acceptable. Here is a live demo of sqlingvo interactive docs. What do you think @r0man ? |
|
@viebel Hmm, but it still takes quite some time to load. And I wonder how time goes up when you add more examples into the sqlingvo.core namespace. |
|
I think everything above the "Detailed SQL examples" section of Everything in the "Detailed SQL examples" section of the README.org
But let's start with the select examples and see how it goes. Or maybe the insert examples, because they are more and we can see how it affects load time? |
|
I also would suggest to look into the indentation first. If proper indentation is not possible and the examples look too ugly, the exercise is a bit pointless. |
The only change required to make the code self-host compatible was to remove the
defdbcalls indb.cljc.