Restore pre-3.3 local_snapshotter() argument order

[hadley]

Part of r-lib/devtools#2631

[claude]

Claude finished @hadley's task —— View job

---

Code Review Complete

Reviewing PR: Restore pre-3.3 local_snapshotter() argument order

Todo List:

• Read repository guidelines (CLAUDE.md)
• Examine changed files to understand modifications
• Check for potential bugs or issues
• Provide review feedback

Analysis

This PR changes the argument order in local_snapshotter() function:

• Before: reporter first, then snap_dir
• After: snap_dir first, then reporter

Changes made:

1. R/snapshot-reporter.R:233-234: Swapped parameter order in function definition
2. R/test-files.R:321: Updated function call to use explicit parameter name reporter = snap_base
3. man/local_snapshotter.Rd: Updated documentation to match new parameter order
4. NEWS.md: Added changelog entry

Review

LGTM. All existing calls use named arguments or default values, so the change is backward compatible.

---