fix: Improve error handling of non-existent/non-accessible filepaths#232
Open
ahl27 wants to merge 2 commits intor-lib:mainfrom
Open
fix: Improve error handling of non-existent/non-accessible filepaths#232ahl27 wants to merge 2 commits intor-lib:mainfrom
ahl27 wants to merge 2 commits intor-lib:mainfrom
Conversation
Author
|
tests seem to be failing due to a CRAN error, not because of changes in this PR. |
Author
|
added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found a small bug, figured it would be faster to include a fix for it with the report.
Running
rcmdcheckon a filepath that doesn't exist produces an uninformative error:This is because
file.info(path)returns allNAvalues ifpathis either non-existent or not readable. I encountered this when I accidentally had a small typo in the path to the package I wanted to test.This fix wraps the
file.info(path)$isdircall with some other error handling to produce more informative errors (and potentially allow for other handling / custom error messages later). It also handles the case where the file/directory exists, but isn't readable. Also included a unit test.New version: