Skip to content

use libpath arg during build#196

Merged
gaborcsardi merged 6 commits intor-lib:mainfrom
pawelru:main
May 15, 2025
Merged

use libpath arg during build#196
gaborcsardi merged 6 commits intor-lib:mainfrom
pawelru:main

Conversation

@pawelru
Copy link
Contributor

@pawelru pawelru commented Feb 15, 2023

closes #195

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2023

Codecov Report

Merging #196 (cbcee23) into main (b82f540) will decrease coverage by 0.20%.
The diff coverage is 100.00%.

❗ Current head cbcee23 differs from pull request most recent head e4aeee7. Consider uploading reports for the commit e4aeee7 to get more accurate results

@@            Coverage Diff             @@
##             main     #196      +/-   ##
==========================================
- Coverage   80.83%   80.63%   -0.20%     
==========================================
  Files          19       19              
  Lines        1007     1007              
==========================================
- Hits          814      812       -2     
- Misses        193      195       +2     
Impacted Files Coverage Δ
R/build.R 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pawelru
Copy link
Contributor Author

pawelru commented Mar 30, 2023

Hi @gaborcsardi can you please have a look? I think it's a quick fix out there. Not sure if you like the test case though.

@gaborcsardi gaborcsardi merged commit 2244576 into r-lib:main May 15, 2025
13 checks passed
@gaborcsardi
Copy link
Member

I am sorry for the long delay and thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

libpath argument is not respected during build step

3 participants