feat: Add Config/build/never-clean option to never clean during build#204
Merged
gaborcsardi merged 1 commit intomainfrom Apr 27, 2025
Merged
feat: Add Config/build/never-clean option to never clean during build#204gaborcsardi merged 1 commit intomainfrom
Config/build/never-clean option to never clean during build#204gaborcsardi merged 1 commit intomainfrom
Conversation
Member
|
Thanks! I am not even sure why Maybe we could remove |
Member
|
OK, I see now that changing a header file does not trigger recompilation of the objects that use it, so that's why we have I am still not sure why a missing DLL would need a cleanup. |
Member
|
In the meanwhile I don't mind adding this flag. |
Member
Author
|
Thanks. Added NEWS and docs in e4e5fb8 . R has a
Let's see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is this something you would support? Happy to add documentation. Do we need a test?
My use cases are duckdb and igraph -- if I need a clean rebuild, I clean, otherwise I'm happy with incremental compiles. The auto-clean gets triggered too frequently, I'm frustrated by it more often than not. The
bootstrap.Rscript doesn't seem to get run withload_all().