Interleaved page -> slab padding fix #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Page buffer isn't sorted per slab, but in the order they are created (they must retain like this as well for pointer conversions done in the runtime). However, we never accounted for this when padding out slabs and pages causing them to be padded out incorrectly as the prior page could belong to a different slab. Code now tracks to which slab the page belongs and independently handles the alignment thereof. Paks generated by RePak are now identical to retail.
Make sure we never allocate more than 20 slabs, as this is the limit of what the runtime can have.
Owner
|
looks good to me!! thank you for the fix! |
r-ex
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Page buffer isn't sorted per slab, but in the order they are created (they must retain like this as well for pointer conversions done in the runtime). However, we never accounted for this when padding out slabs and pages causing them to be padded out incorrectly as the prior page could belong to a different slab. Code now tracks to which slab the page belongs and independently handles the alignment thereof. Paks generated by RePak are now identical to retail.
Also added a guard to make sure we never allocate more than 20 slabs, as this is the limit of what the runtime can have.
Paks generated with this fix now correctly pass all the debug validation checks implemented in the latest RSX build.