fix(qwik-nx): drop deprecated readWorkspaceConfig in favor of readCachedProjectGraph#248
Merged
dmitry-stepanenko merged 1 commit intoqwikifiers:mainfrom May 13, 2025
Conversation
…CachedProjectGraph`
commit: |
Contributor
|
@edbzn thank you! Just FYI, in the recent versions qwik itself now has a capability of resolving library paths, so qwikNxVite plugin is no longer needed. I'm going to add a migration for the v4 (upcoming release for nx@21) to fully remove the plugin from the users codebase. Meanwhile let's merge this as it might be helpful for those who still use older versions of Qwik |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description
In our CI, we face a sporadic timeout issue when running a test target that involves
qwikNxVite. This change fixes the problem by using the right way to get the project graph and project configs, dropping the deprecatedreadWorkspaceConfigAPI in favor of the devkit.Note that Nx 21 removed the function, so it's a needed refactoring anyway.
Use cases and why
No sporadic timeout issue when running a test target including
qwikNxVite.Screenshots/Demo
Checklist: