FIX #245: Error while running nx generate qwik-nx:app#246
Merged
dmitry-stepanenko merged 3 commits intoqwikifiers:mainfrom May 12, 2025
Merged
FIX #245: Error while running nx generate qwik-nx:app#246dmitry-stepanenko merged 3 commits intoqwikifiers:mainfrom
nx generate qwik-nx:app#246dmitry-stepanenko merged 3 commits intoqwikifiers:mainfrom
Conversation
commit: |
Contributor
|
Hey @lfroes thanks for your PR and patience 😄 I've pushed a small enhancement on top |
b88255a to
cfbbb02
Compare
cfbbb02 to
ba37969
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description
Resolved #245, created compatibility with
nx: 20.7.1.The current issue was happening because of the
ensureProjectNamefunction, now that nx has updated and this does not work like used to do.I Have done quick fix so the package can be used with the nx 20.7.1, still need some advice on how to make it work when the user do not use the
--nameflag with the command, maybe create a default name likemyAppandmyLib?Use cases and why
Actual behavior:
nx 20.7.1we are unable to generate new apps or libsExpected behavior:
nx generate qwik-nx:appshould work withnx 20.7.1Screenshots/Demo
N/A
Checklist: