Fix pip issue & Add support to custom endpoint_url, region_name and signature_version#43
Open
M0dM wants to merge 10 commits intoqwigo:developfrom
Open
Fix pip issue & Add support to custom endpoint_url, region_name and signature_version#43M0dM wants to merge 10 commits intoqwigo:developfrom
M0dM wants to merge 10 commits intoqwigo:developfrom
Conversation
Author
|
Everything seems to work well on my side. Regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to fix #42
I could not test it...
I have a strange issue on master :
Edit: pip issue (#44) Problem fixed by commit 613e2c7
I need also region_name argument to be set, I will try to add it as well in a new commit...
This will be easier as this attribute can be set directly when instanciating the session.
Edit: region_name and signature_version are also usefull to make kev work with minio