Refactor context management for program builders#933
Merged
Conversation
Test Results 6 files 6 suites 7m 3s ⏱️ Results for commit 1c6516f. ♻️ This comment has been updated with latest results. |
Member
Author
|
@Nomos11 triggered by properly implementing minimal sample rate |
Nomos11
reviewed
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces
PulseTemplate._create_program(**a_lot_of__kwargs)withPulseTemplate._build_program(program_builder).It moves all the information about the current scope, transformations, channel and measurement mappings into the program builder.
ProgramBuilder.build_context: BuildContext: A dataclass with mutable information like the current scopeProgramBuilder.build_settings: BuildSettings: A dataclass with constant information like which templates to translate into a single waveformProgram.get_defined_channels.ProgramBuilder.overrideto modify the current built settings/context.ProgramBuilder.with_mappingsforMappingPTProgramBuilder.with_transformationfor arithmetic and channel modification PTsProgramBuilder.with_metadatafor a semi standadized metadata passing. The only read metadata right now is the minimal sample rate.ProgramBuilder.inner_scopebecause it is no longer required.To reduce code duplication the PR contains the
BaseProgramBuilderclass which contains some default implementations for context management which are shared between the loop and linspace builder.TODO: