fix issue with incorect handling missing paths#4
Open
Irioth wants to merge 1 commit intoqustavo:masterfrom
Open
fix issue with incorect handling missing paths#4Irioth wants to merge 1 commit intoqustavo:masterfrom
Irioth wants to merge 1 commit intoqustavo:masterfrom
Conversation
Due to creation of new router in func registerPaths, we losing NotFoundHandler. And proxy incorrectly disallow such API with 404. This pull request intended to fix that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to creation of new router in func registerPaths, we losing NotFoundHandler. And proxy incorrectly disallow such API with 404. This pull request intended to fix that.