Fix Completely non functional armor

[LemonatedCat]

• Make Armor look up its slot on creation
• Make Knockback resistance no longer hardcoded to main hand
• Make Different Pieces or Armor give their respective armor Values instead of an average

This does NOT fix Crstalite Armor that was already crafted due to how infusion works.

Affected Pieces of equipment:

• Terminite Armor
• Thallasium Armor
• Crystal Armor
• Crystal Elytra

closes #514

[LemonatedCat]

the changes to attribute IDs is because even when using AttributeModifier.Operation.ADD_VALUE, attributes do not stack unless they have different ids. Might need to apply this to BASE_KNOCKBACK_RESISTANCE too if anything else uses it.

[LemonatedCat]

This also seems to not just affect 1.21, but alot of versions like 1.20.3 too.

[ghost]

so we have to change the code ourselves inorder to make it works?

[Haskatings]

Hello, with a friend of me, we have try to apply all the change you put in #518 ,

We have two questions :

In betterx/betterend/ files are in extension ".class" shall we download your .java file and change the extension before replace the original file in the destination ?

where is the file "build.gradle" ? we don't find it, where shall we put it ?

Ty by advance for your response !

[The13Discs]

Hello, never used GitHub before, nor have i messed with mods, but could i ask for a dumbed down explanation as to how to apply changes to the code, and replace the prior one?

Thank you ahead of time!

[LemonatedCat]

Sorry for the late response, this should have been long merged...

You need to download these two and unpack them (Both in the same directory):
https://github.com/quiqueck/BCLib/archive/refs/heads/1.21.zip
https://github.com/BenCat07/BetterEnd/archive/refs/heads/1.21.zip

Edit the build.gradle in both of them, and remove this line:
apply from: "helper.gradle"

In BetterEnd inside the settings.betterx.gradle change this line:
def allowLocalLibInConsoleMode = false
to
def allowLocalLibInConsoleMode = true

After that, run this in the BCLib Folder:
gradlew.bat genSources
gradlew.bat remapSourcesJar
gradlew.bat remapJar

After that, run this in the BetterEnd Folder
gradlew.bat genSources
gradlew.bat remapJar

After you ran both Commands in both directories, you should get a better-end-[...].jar inside of BetterEnd/build/libs, which you can just put in your mods folder, and that of your server, if you use one.

Errors

If you get a java version error while doing these steps (e.g. Failed to setup Minecraft, java.lang.IllegalStateException: Minecraft 1.21.1 requires Java 21 but Gradle is using 19)
You need to download the java version mentioned, and add the Path to the gradle.properties file of both projects like this:
org.gradle.java.home=C:/Program Files/Eclipse Adoptium/jdk-21.0.2.13-hotspot

Of course, with the right path instead of mine.

Other Errors?

Sorry, but i do not really have the time to look into those. You might find some look by just copying the error into google and finding it, but that's about it.

[Umul0]

Hey, I just wanted to say a huge thank you for your work on this
I actually created a GitHub account just to leave this comment — your fix completely solved my issue, and it honestly lifted a lot of frustration I had.
Thanks again for sharing your work!

[Miquel-TA]

Thank you so much guys. Patching the jsons and recreating the jars worked for me, but I ended up giving up anyway. So many armors, tools and entities are fucked. Fixing them manually on a multiplayer server means hours of work, testing and downtime. It's just not worth the hustle.