Fix compatibility with Julia 1.13+ memhash removal#320
Open
vtjnash wants to merge 1 commit intoquinnj:mainfrom
Open
Fix compatibility with Julia 1.13+ memhash removal#320vtjnash wants to merge 1 commit intoquinnj:mainfrom
vtjnash wants to merge 1 commit intoquinnj:mainfrom
Conversation
Remove hash method definition when Base.memhash is not available. On Julia 1.13+, these AbstractString types will use the default AbstractString hash implementation which is now efficient and zero-copy based on codeunit/iterate. For Julia <1.13, continue using the memhash-based implementation for compatibility. Related to JuliaLang/julia#59697 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
@quinnj I understand this package is deprecated, but would it perhaps still make sense to merge this PR and get a last (?) release out, to help tide those who still need JSON3 for now? |
Author
|
bump? I don't even care if you make a new release, just getting the PR out of my list would help me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove hash method definition when Base.memhash is not available.
On Julia 1.13+, these AbstractString types will use the default
AbstractString hash implementation which is now efficient and
zero-copy based on codeunit/iterate.
For Julia <1.13, continue using the memhash-based implementation
for compatibility.
Related to JuliaLang/julia#59697
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com