Open
Conversation
Author
|
Failing CI looks unrelated to this PR (Some Int64 vs Int32 error for Arrow compatibility on Windows, invalid kwarg to |
quinnj
reviewed
Dec 18, 2024
Author
|
I'm opting for It seems the least disruptive and still a win. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the usefulness and performance of
Base.show-ing nestedJSON3.Objects.Here's an example with the Plotly.JS schema. It takes several seconds to show the Object, and no information about the nested objects has been provided:
With this PR:
Note that the top level show method uses
show(::IO, ::MIME"text/plain", ::AbstractDict)and nested objects useshow(::IO, ::Object).This will break any downstream code that relied on
Base.show(::IO, ::Object)to generated valid JSON. If valid JSON is a requirement I'd propose changingBase.show(io::IO, obj::Object) = JSON3.write(io, obj). It's still slow at about 1 second, but it at least would show some of the contents: