More robust handling of filenames, paritucalrly errors about too long#264
Open
nstiurca wants to merge 2 commits intoquinnj:mainfrom
Open
More robust handling of filenames, paritucalrly errors about too long#264nstiurca wants to merge 2 commits intoquinnj:mainfrom
nstiurca wants to merge 2 commits intoquinnj:mainfrom
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #264 +/- ##
==========================================
- Coverage 89.69% 89.67% -0.02%
==========================================
Files 10 10
Lines 1775 1782 +7
==========================================
+ Hits 1592 1598 +6
- Misses 183 184 +1
☔ View full report in Codecov by Sentry. |
quinnj
reviewed
Sep 16, 2023
| true | ||
| catch e | ||
| if isa(e, Base.IOError) | ||
| e.code != -36 # -36 is ENAMETOOLONG; other IO errors indicate valid filename |
Owner
There was a problem hiding this comment.
is this code consistent across OS platforms? can we add a test to catch the new code paths here?
Author
There was a problem hiding this comment.
I suspect the original code might work as intended on Windows, and this branch wouldn't ever be triggered. Still, yeah I'll try to write a test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On my system, I'm actually triggering the
ENAMETOOLONGerror code with strings of length ~150 characters. Not sure why, but I re-wrote the code based on the suggestion in the upstream bug.