This repository was archived by the owner on Oct 6, 2022. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 3
Official client release #30
Open
quinchs
wants to merge
48
commits into
dev
Choose a base branch
from
future/official-client-release
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
03b7612 to
5999a18
Compare
* add custom type converters * add example for custom type converter * fix property type invalid reference
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains modifications to the dotnet driver API to standardize it with other drivers and changes related to feedback provided by the EdgeDB team.
Changes
State (config, aliases, module, globals)
The state API has changed to follow the other drivers (js/ts, python, go, rust) and is defined like so:
There are now 4 methods exposed on
EdgeDBClientcalledWithConfig,WithGlobals,WithModule, andWithAliaseswhich will return a newEdgeDBClientthat shares the same client pool as its parent (baseClientin this example)1.Object Deserialization
The deserialization step has been optimized to remove the intermediate dynamic object in favor for a
ObjectEnumeratortype which acts like anIEnumerator. The new method is designed to be fast and play well with the current binary workflow.Benchmarks
Deserializing the type
PersonTODO's
Node
The official release is just for the
EdgeDB.Net.Driverpackage, the query builder is still in developmentFootnotes
see the js implementation. ↩