Use cp -r instead of "Copy Files"
#3080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'Copy Files' never properly let XCode know about `Quicksilver.pch`, so we've required a separate "empty" step just for dependency resolution for quite some time. For some reason when building a Release build (with `Archive`), this step wasn't working properly. Instead, we can replace both steps with just a `cp -r` which seems to serve both purposes and allows a Release / Archive build from scratch.
Member
|
Build seems to be working fine on CI. Do you have a GH issue or relevant link for context on what this is solving? |
Member
Author
|
Try doing a local Product -> Archive, after cleaning everything (including /tmp/QS). For me this consistently fails, /tmp/QS/Configuration is empty. |
Member
Author
|
Also, if you look at the contents of this step on current |
Member
|
OK, sounds good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'Copy Files' never properly let XCode know about
Quicksilver.pch,so we've required a separate "empty" step just for dependency resolution
for quite some time.
For some reason when building a Release build (with
Archive), thisstep wasn't working properly.
Instead, we can replace both steps with just a
cp -rwhich seems toserve both purposes and allows a Release / Archive build from scratch.