Skip to content

Avoid QoS inversion when loading scripts #3063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
n8henrie wants to merge 1 commit into from
Closed

Avoid QoS inversion when loading scripts #3063

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions Quicksilver/PlugIns-Main/QSCorePlugIn/Code/QSAppleScriptActions.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,9 +414,12 @@ -(NSInteger)argumentCountForScript:(NSString *)scriptPath {
int pid = [[NSProcessInfo processInfo] processIdentifier];
NSAppleEventDescriptor* targetAddress = [[NSAppleEventDescriptor alloc] initWithDescriptorType:typeKernelProcessID bytes:&pid length:sizeof(pid)];

NSDictionary *errorDict = nil;
NSAppleScript *script = [[NSAppleScript alloc] initWithContentsOfURL:[NSURL fileURLWithPath:scriptPath] error:&errorDict];
NSDictionary __block *errorDict = nil;
NSAppleScript __block *script;

QSGCDMainSync(^{
script = [[NSAppleScript alloc] initWithContentsOfURL:[NSURL fileURLWithPath:scriptPath] error:&errorDict];
});
event = [[NSAppleEventDescriptor alloc] initWithEventClass:kQSScriptSuite eventID:kQSGetArgumentCountCommand targetDescriptor:targetAddress returnID:kAutoGenerateReturnID transactionID:kAnyTransactionID];

NSAppleEventDescriptor *result = [script executeAppleEvent:event error:&errorDict];
Expand Down
Loading