[WIP] Fixes for Sequoia #3025
[WIP] Fixes for Sequoia #3025
Conversation
…ed) /Applications folder
…ragging/dropping multiple objects Fixes #3014
+ WIP - other animations
…out this being hacky
…ts the right icon gst
…n't always before)
…a trigger (could still be better)
…option was disabled, causing the results view to display immediately
n8henrie
left a comment
n8henrie
left a comment
There was a problem hiding this comment.
Wow, tremendous effort. Thanks Paddy!
| // the object isn't a file/doesn't exist, so return. shouldn't actually happen | ||
| if (![manager fileExistsAtPath:path]) { | ||
| __block BOOL exists = YES; | ||
| QSGCDMainSync(^{ |
There was a problem hiding this comment.
I assume this change makes this run on the main thread instead of a lower priority background thread?
There was a problem hiding this comment.
Yeah, if you're going to get into GCD, you should familiarise yourself with the QSGCD methods I made. They're basic wrappers but make things a little but easier.
This was needed because sometimes this would happen on a background thread, and file reads have to happen on the main thread.
| if (!includeTypes) { | ||
| includeTypes = @[NSStringPboardType, QSTextType]; | ||
| } | ||
| NSLog(@"WARNING: This method is deprecated, ignoring the declareTypes and includeTypes parameters"); |
There was a problem hiding this comment.
Should we just get rid of the additional instances? Or is the issue that it might be called from plugins? (In which case maybe another benefit of monorepo, being able to more confidently change our API.)
There was a problem hiding this comment.
Exactly - I originally just deleted them but then clipboard plugin crashed, because it was using it. If we have a monorepo we don't need to worry too much because we can just do a global search and replace, but still - we shouldn't just delete methods (like I did!) because if someone is running an old QS with a new plugin or vice versa it will cause a crash.
There was a problem hiding this comment.
(Oh and another example of why deleting methods is bad - when the [QSWindow flare] method was deleted as part of the CGSPrivate, because it no longer existed it broke the yosemite interface (now fixed)
| // NSLog(@"types %@", [pboard types]); | ||
| return YES; | ||
| - (BOOL)putOnPasteboard:(NSPasteboard *)pboard includeDataForTypes:(NSArray *)includeTypes { | ||
| NSLog(@"WARNING: This method is deprecated, ignoring the includeTypes parameter"); |
There was a problem hiding this comment.
I don't see any other calls to this in the main QS codebase at first glance.
There was a problem hiding this comment.
Clipboard was using it (but I fixed that). I don't know about other plugins...
…eck if an object is in the catalog or not
This reverts commit c36bdcf.
…y when tests are running
…rd cryptexes folder
- saving objects to a shelf - scanning catalog entries
pjrobertson
force-pushed
the
sequoia-fixes
branch
from
65e77ea to
90335fa
Compare
| [newActions addObject:kQSObjectShowChildrenAction]; | ||
| } | ||
| if ([[QSLibrarian sharedInstance] firstEntryContainingObject:dObject]) | ||
| if ([dObject objectForMeta:QSCatalogStructureChanged] || [[QSLibrarian sharedInstance] firstEntryContainingObject:dObject]) |
There was a problem hiding this comment.
I'm wondering if this is why I'm not seeing show source in catalog for those odd catalog entries (that look like they're bullet points from some kind of note file)?
There was a problem hiding this comment.
My results for asdf (which is my synonym for clipboard history, but none of these are on my clipboard history):
You can barely see, but the "echo" item is selected in the left pane, and I've searched for source in the second:
Show source in catalog has completely disappeared from my actions:
|
Figured this out -- was running from an "archive" copy instead of the blessed build path! |
Uh oh!
There was an error while loading. Please reload this page.