Skip to content

new default behavior and new options#25

Open
jeffhawke wants to merge 1 commit intoquentinsf:masterfrom
jeffhawke:new_options
Open

new default behavior and new options#25
jeffhawke wants to merge 1 commit intoquentinsf:masterfrom
jeffhawke:new_options

Conversation

@jeffhawke
Copy link

new default behavior: do not keep track of the ids of all the folders, only check a folder content against itself

new options: --all to automatically parse all folders, --global to restore the global check behavior for folders

…, only check a folder content against itself

new options: --all to automatically parse all folders, --global to restore the global check behavior for folders
@quentinsf
Copy link
Owner

Hi Jeff - I'm sorry for the delay in merging this - it looks good, though. My only concern is that the --global option changes the current default behaviour. I'm not sure if many people use this in scripts, cron jobs etc, but I wouldn't want to surprise them!

So I'd be tempted to leave the current behaviour and add a --local if you only want to check for duplicates in the same mailbox. What do you think?

Quentin

@jeffhawke
Copy link
Author

Hi, thanks for answering. Yes, your solution works as well and it may be less disruptive of existing use cases.
Mostly, I went and changed the default behavior because I felt that only checking against every folder was the "expected" result, but then maybe it's just me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants