new default behavior and new options#25
Open
jeffhawke wants to merge 1 commit intoquentinsf:masterfrom
Open
Conversation
…, only check a folder content against itself new options: --all to automatically parse all folders, --global to restore the global check behavior for folders
Owner
|
Hi Jeff - I'm sorry for the delay in merging this - it looks good, though. My only concern is that the --global option changes the current default behaviour. I'm not sure if many people use this in scripts, cron jobs etc, but I wouldn't want to surprise them! So I'd be tempted to leave the current behaviour and add a --local if you only want to check for duplicates in the same mailbox. What do you think? Quentin |
Author
|
Hi, thanks for answering. Yes, your solution works as well and it may be less disruptive of existing use cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new default behavior: do not keep track of the ids of all the folders, only check a folder content against itself
new options: --all to automatically parse all folders, --global to restore the global check behavior for folders