Improve tx priority #688
Open
Improve tx priority #688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve how transaction priority is computed for new entities.
src/ticking/pending_txs_pool.h
Outdated
| // latestTransferTick = latestOutgoingTransferTick if latestOutgoingTransferTick > 0, | ||
| // latestTransferTick = latestIncomingTransferTick otherwise (new entity). | ||
| const EntityRecord& entity = spectrum[sourceIndex]; | ||
| const auto latestTransferTick = (entity.latestOutgoingTransferTick) ? entity.latestOutgoingTransferTick : entity.latestIncomingTransferTick; |
Collaborator
There was a problem hiding this comment.
I'm not a big fan of auto when it's not a complex type. Here I'd prefer writing unsigned int explicitly.
src/ticking/pending_txs_pool.h
Outdated
| // latestTransferTick = latestIncomingTransferTick otherwise (new entity). | ||
| const EntityRecord& entity = spectrum[sourceIndex]; | ||
| const auto latestTransferTick = (entity.latestOutgoingTransferTick) ? entity.latestOutgoingTransferTick : entity.latestIncomingTransferTick; | ||
| priority = smul(balance, static_cast<sint64>(tx->tick - latestTransferTick + 1)); |
Collaborator
There was a problem hiding this comment.
While you're anyways touching this file, could you use math_lib::smul here to get rid of the qpi.h include? (we didn't have smul available outside qpi before but I moved it to math_lib for the contract exec fees)
Franziska-Mueller
approved these changes
Dec 18, 2025
Collaborator
Franziska-Mueller
left a comment
Franziska-Mueller
left a comment
There was a problem hiding this comment.
looks good now!
I suggest to wait with merging to develop until we have the first non-seamless transition after the holidays. I'd like to keep develop in a non-breaking state to facilitate optional updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve how transaction priority is computed for new entities.
https://discord.com/channels/@me/1167399046357471242/1450385128978251796