settings: Add organization and user settings (PROJQUAY-4553)#171
settings: Add organization and user settings (PROJQUAY-4553)#171jonathankingfc wants to merge 19 commits intomainfrom
Conversation
jonathankingfc
commented
Jan 24, 2023
jonathankingfc
commented
- This PR includes a few features that enhance the org/settings customization flows
- Users can now convert their account from individual to organization
- Users can update their e-mail and other similar metadata regarding their account
- Error handling has been added to the settings pages / clear back to defaults
- Added ability to generate CLI token for user account
- This PR includes a few features that enhance the org/settings customization flows - Users can now convert their account from individual to organization - Users can update their e-mail and other similar metadata regarding their account - Error handling has been added to the settings pages / clear back to defaults - Added ability to generate CLI token for user account
| import {BillingInformation} from './BillingInformation'; | ||
| import {CliConfiguration} from './CLIConfiguration'; | ||
|
|
||
| const GeneralSettings = () => { |
There was a problem hiding this comment.
I see this variable defined in GeneralSettings.tsx and one of it doesn't seem to be referenced anywhere. Could you take a look?
| View Invoices | ||
| </Button> | ||
|
|
||
| {isUserOrganization && ( |
There was a problem hiding this comment.
I am unable to see this additional settings field for a user
harishsurf
left a comment
harishsurf
left a comment
There was a problem hiding this comment.
Overall looks good. Left some minor comments. The Change plan slider seen in mocks doesn't seem to be implemented - not sure if it was decided to not have it? but just wanted to call out so that it doesn't get missed
| </HelperText> | ||
| <FormGroup | ||
| isInline | ||
| label="Admin Username" |
There was a problem hiding this comment.
nit: mocks show this to just Username
| </FormGroup> | ||
| <FormGroup | ||
| isInline | ||
| label="Admin Username" |
There was a problem hiding this comment.
label would be password
| <Tbody> | ||
| {paginatedBulkItemsList.map((item, idx) => ( | ||
| <Tr key={idx}> | ||
| <Td>{item.name}</Td> |
There was a problem hiding this comment.
The mock shows the org names to be clickable
| import {GenerateEncryptedPassword} from 'src/components/modals/GenerateEncryptedPasswordModal'; | ||
| import {useState} from 'react'; | ||
|
|
||
| export const CliConfiguration = () => { |
There was a problem hiding this comment.
This doesn't seem to be called anywhere?
2 participants
