OPCUA-3289: New pipeline for LogIt#15
Conversation
luismiguensfernandez
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 95fa58f68b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| list(APPEND CMAKE_PREFIX_PATH "${BOOST_HOME}") | ||
| set(Boost_USE_STATIC_LIBS ON) | ||
| set(Boost_USE_STATIC_RUNTIME ON) | ||
| find_package(Boost CONFIG REQUIRED COMPONENTS log) |
There was a problem hiding this comment.
find_package(Boost CONFIG REQUIRED COMPONENTS log) forces config-mode discovery, so builds now fail on environments that only have distro Boost packages (which provide FindBoost but no BoostConfig.cmake). In this repo, configuring with LOGIT_BACKEND_BOOSTLOG=ON and BOOST_HOME=/usr already errors with “Could not find a package configuration file provided by Boost”, which is a regression from the previous find_package(Boost REQUIRED ...) behavior and blocks common Linux builds.
Useful? React with 👍 / 👎.
| endif() | ||
|
|
||
| if(LOGIT_EXTRA_LINK_LIBS) | ||
| target_link_libraries(LogIt PUBLIC ${LOGIT_EXTRA_LINK_LIBS}) |
There was a problem hiding this comment.
This links LogIt even when it is created as an OBJECT library (the default when LOGIT_BUILD_SHARED_LIB=OFF), but the project still declares cmake_minimum_required(VERSION 3.10). Per CMake’s add_library docs, linking object libraries via target_link_libraries is only supported starting in 3.12, so Boost/UATRACE-enabled configurations can fail on 3.10/3.11 despite the stated minimum version.
Useful? React with 👍 / 👎.
1 participant
@codex