parcoords.py: Fix get_limits compatibility with pandas 3.0 string dtype #440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pandas 3.0 now infers string columns as the dedicated string dtype instead of object dtype by default. This caused get_limits() to fail recognizing categorical columns, returning individual values instead of sets of unique values. The fix adds a check for string dtype using pd.api.types.is_string_dtype() alongside the existing object dtype check, ensuring categorical/string columns are properly handled regardless of pandas version. Fixes test failures in test_get_limits and test_plot when using pandas 3.0.0rc1 (--pre flag).
EwoutH
force-pushed
the
fix_get_limits_pd3
branch
from
94475ef to
9886c8d
Compare
EwoutH
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pandas 3.0 now infers string columns as the dedicated string dtype instead of object dtype by default. This caused
get_limits()to fail recognizing categorical columns, returning individual values instead of sets of unique values.The fix adds a check for string dtype using
pd.api.types.is_string_dtype()alongside the existing object dtype check, ensuring categorical/string columns are properly handled regardless of pandas version.Fixes test failures in test_get_limits and test_plot when using pandas 3.0.0rc1 (--pre flag).
This issue was detected by our pre-release CI run. I think this warrants a backport to 2.5.x and maybe a patch release.