Open
Conversation
…ken by actual gates, this way circuits can be tetrised. Also stopped builder from splitting setup into component pieces upon initialisation
slavoutich
reviewed
Feb 13, 2019
Collaborator
slavoutich
left a comment
slavoutich
left a comment
There was a problem hiding this comment.
Would be nice also to add test that uses_waiting_gates actually matters, but I don't insist. The only serious note is about topo_order -> toposort change, better to leave it as it was.
| the experiment. | ||
|
|
||
| kwargs: Can add t1 and t2 via the kwargs instead of | ||
| passing them with the qubit_dic. |
Collaborator
There was a problem hiding this comment.
Kinda weak explanation here (I would not be able to understand). May be better link it to Quantumsim circuit documentation?
| Script to run to finalize gates. Currently adds waiting gates | ||
| as required and sorts gates. | ||
|
|
||
| Args: |
Collaborator
There was a problem hiding this comment.
Numpydoc's keyword is Parameters, not Args
| """ | ||
| Function to add waiting gates to system | ||
|
|
||
| Args: |
| update_function_dic[rule](self, **kwargs) | ||
|
|
||
| def finalize(self, topo_order=False, t_add=0): | ||
| def finalize(self, toposort=False, tmin=None, tmax=None, |
Collaborator
There was a problem hiding this comment.
I would not rename topo_order to toposort without extra need: larger chance to get reverse incompatibility in the case of someone called the function as finalize(topo_order=True).
Collaborator
|
Sorry, completely missed the existence of this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added option to auto-shrink waiting gates to only include the time taken by actual gates, this way circuits can be tetrised. Also stopped builder from splitting setup into component pieces upon initialisation.
@slavoutich , @xabomon , can one of you check this out?