Fix gitstatus build failure with Apple Clang 17 (Xcode 16+)#19
Open
alejandroqh wants to merge 1 commit intoquantumnic:masterfrom
Open
Fix gitstatus build failure with Apple Clang 17 (Xcode 16+)#19alejandroqh wants to merge 1 commit intoquantumnic:masterfrom
alejandroqh wants to merge 1 commit intoquantumnic:masterfrom
Conversation
|
I manually made this change, and I was able to build gitstatusd afterwards. |
romkatv
added a commit
to romkatv/gitstatus
that referenced
this pull request
Mar 14, 2026
From quantumnic/powerlevel10k#19 by @alejandroqh. Apple Clang 17 predefines TARGET_OS_MAC=1, which activates an ancient classic Mac OS code path in the bundled zlib. The fdopen macro replaces the system _stdio.h declaration of fdopen() with NULL, producing a parse error. Error: _stdio.h:322:7: error: expected identifier or '(' FILE *fdopen(int, const char *) ... zutil.h:140:33: note: expanded from macro 'fdopen' #define fdopen(fd,mode) NULL /* No fdopen() */ Fix: use system zlib instead of the bundled one. Add -lz to gitstatus_ldlibs to link against system zlib Add -DUSE_BUNDLED_ZLIB=OFF to libgit2 cmake flags
|
@alejandroqh Thanks for the PR. I've merged it upstream: romkatv/gitstatus@075baf6 |
Author
Thanks to you for merge it. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apple Clang 17 predefines TARGET_OS_MAC=1, which activates an ancient classic Mac OS code path in the bundled zlib. The fdopen macro replaces the system _stdio.h declaration of fdopen() with NULL, producing a parse error.
Error:
Fix: use system zlib instead of the bundled one.