Fix migrate.zsh crash when Zinit is not installed#15
Open
alejandroqh wants to merge 1 commit intoquantumnic:masterfrom
Open
Fix migrate.zsh crash when Zinit is not installed#15alejandroqh wants to merge 1 commit intoquantumnic:masterfrom
alejandroqh wants to merge 1 commit intoquantumnic:masterfrom
Conversation
When ZINIT is not declared as an associative array (i.e. the user
does not use Zinit), accessing ${ZINIT[PLUGINS_DIR]:-/dev/null}
under set -u (nounset) causes zsh to abort with:
PLUGINS_DIR: parameter not set
Fix by declaring ZINIT as an associative array if it is not already
set, so the :- fallback works as intended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PLUGINS_DIR: parameter not seton systems without Zinitset -u(nounset), which causes${ZINIT[PLUGINS_DIR]:-/dev/null}to error when theZINITassociative array is undeclaredZINITas an associative array if not already set, so the:-fallback works as intendedSteps to reproduce
zsh <(curl -fsSL https://raw.githubusercontent.com/quantumnic/powerlevel10k/master/migrate.zsh)