change make_channel to take in privacy bool, auto-invite all members … #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of group if false and leave empty if true -- issue quantumish#12
quantumish
requested changes
Nov 24, 2022
Owner
quantumish
left a comment
quantumish
left a comment
There was a problem hiding this comment.
Left a few syntax-related pieces of feedback. Also, could you update any calls to this method so that they include this new change? Off the top of my head I think it should just be the call in tests.rs, but probably worth double checking so that things don't crash.
scuttlebutt/src/main.rs
Outdated
| self.db.add_group_channel(gid.0, cid).unwrap(); | ||
| channel = db.get_channel(cid).unwrap(); | ||
| if private { // making the channel private | ||
| make_channel_private(channel) |
Owner
There was a problem hiding this comment.
I think this needs a semicolon in order to compile
scuttlebutt/src/main.rs
Outdated
| if private { // making the channel private | ||
| make_channel_private(channel) | ||
| } | ||
| else // adding existing users to channel |
| else // adding existing users to channel | ||
| let users = self.db.get_group_users(gid.0).unwrap(); | ||
| for user in users { | ||
| self.db.add_channel_member(channel, user).unwrap(); |
scuttlebutt/src/main.rs
Outdated
| let fixed_name = check_name(name.0.clone()); | ||
| self.db.create_channel(cid, gid.0, auth.0.id, fixed_name.clone()).unwrap(); | ||
| self.db.add_group_channel(gid.0, cid).unwrap(); | ||
| channel = db.get_channel(cid).unwrap(); |
Owner
There was a problem hiding this comment.
I think this should be let channel = self.db.get_channel(cid).unwrap();?
Author
|
I just fixed the syntax errors (they were already on my local file, oops) and made it so the tests won't break. The new feature isn't being tested though, so I will write that next. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…of group if false and leave empty if true -- issue #12