feature/go-runner-extras

.gitignore

@@ -184,7 +184,8 @@ __pycache__/
 *.dylib
 bin/
 dist/
-pine-gen
+/pine-gen
+/build/pine-gen
 
 # Test binary, built with `go test -c`
 *.test
@@ -203,7 +204,7 @@ vendor/
 # Temporary files and build artifacts
 tmp/
 temp/
-output/
+/output/
 
 # IDE files
 .idea/
@@ -225,3 +226,7 @@ Thumbs.db
 testdata/output.json
 testdata/sma-output.json
 testdata/*-output.json
+
+# Contribot
+contribot.*.json
+transcripts/

Makefile

@@ -1,7 +1,7 @@
 # Makefile for Runner - PineScript Go Port
 # Centralized build automation following Go project conventions
 
-.PHONY: help build test test-unit test-integration test-e2e test-parser test-codegen test-runtime test-series test-syminfo regression-syminfo bench bench-series coverage coverage-show check ci clean clean-all cross-compile fmt vet lint build-strategy
+.PHONY: help build test test-unit test-integration test-e2e test-golden test-golden-update test-parser test-codegen test-runtime test-series test-syminfo regression-syminfo bench bench-series coverage coverage-show check ci clean clean-all cross-compile fmt vet lint build-strategy
 
 # Project configuration
 PROJECT_NAME := runner
@@ -104,8 +104,8 @@ _cross_compile_platform:
 
 ##@ Testing
 
-# Main test target: runs all tests (unit + integration + e2e)
-test: test-unit test-integration test-e2e ## Run all tests (unit + integration + e2e)
+# Main test target: runs all tests (unit + integration + e2e + golden)
+test: test-unit test-integration test-e2e test-golden ## Run all tests (unit + integration + e2e + golden)
 	@echo "✓ All tests passed"
 
 test-unit: ## Run unit tests (excludes integration)
@@ -115,14 +115,24 @@ test-unit: ## Run unit tests (excludes integration)
 
 test-integration: ## Run integration tests
 	@echo "Running integration tests..."
-	@ $(GOTEST) $(TEST_FLAGS) -tags=integration ./tests/test-integration/...
+	@ $(GOTEST) $(TEST_FLAGS) -tags=integration ./tests/integration/...
 	@echo "✓ Integration tests passed"
 
 test-e2e: ## Run E2E tests (compile + execute all Pine fixtures/strategies)
 	@echo "Running E2E tests..."
 	@./scripts/e2e-runner.sh
 	@echo "✓ E2E tests passed"
 
+test-golden: ## Run golden file regression tests
+	@echo "Running golden file regression tests..."
+	@ $(GOTEST) $(TEST_FLAGS) ./tests/golden/...
+	@echo "✓ Golden tests passed"
+
+test-golden-update: ## Update golden baseline files
+	@echo "Updating golden baseline files..."
+	@ $(GOTEST) -v ./tests/golden/... -update-golden
+	@echo "✓ Golden baselines updated"
+
 test-parser: ## Run parser tests only
 	@echo "Running parser tests..."
 	@ $(GOTEST) $(TEST_FLAGS) ./parser/...

README.md

@@ -4,7 +4,6 @@ High-performance PineScript v5 parser, transpiler, and runtime written in Go for
 
 ## Tooling
 
-- **pine-inspect**: AST parser/debugger (outputs JSON AST for inspection)
 - **pine-gen**: Code generator (transpiles .pine → Go source)
 - **Strategy binaries**: Standalone executables (compiled per-strategy)
 
@@ -20,7 +19,7 @@ make fetch-strategy SYMBOL=BTCUSDT TIMEFRAME=1h BARS=500 STRATEGY=strategies/dai
 make serve-strategy SYMBOL=AAPL TIMEFRAME=1D BARS=200 STRATEGY=strategies/test-simple.pine
 
 # Run with pre-generated data file (deterministic, CI-friendly)
-make run-strategy STRATEGY=strategies/daily-lines.pine DATA=golang-port/testdata/ohlcv/BTCUSDT_1h.json
+make run-strategy STRATEGY=strategies/daily-lines.pine DATA=tests/fixtures/ohlcv/BTCUSDT_1h.json
 ```
 
 ### Build Commands
@@ -58,7 +57,7 @@ make fetch-strategy SYMBOL=SBER TIMEFRAME=1h BARS=500 STRATEGY=strategies/ema-st
 # Reproducible test (no network)
 make run-strategy \
   STRATEGY=strategies/test-simple.pine \
-  DATA=testdata/ohlcv/BTCUSDT_1h.json
+  DATA=tests/fixtures/ohlcv/BTCUSDT_1h.json
 ```
 
 ### Building Standalone Binaries
@@ -134,7 +133,7 @@ make coverage-show   # Opens in browser
 # Run strategy with existing data
 make run-strategy \
   STRATEGY=strategies/daily-lines.pine \
-  DATA=golang-port/testdata/ohlcv/BTCUSDT_1h.json
+  DATA=tests/fixtures/ohlcv/BTCUSDT_1h.json
 
 # Fetch live data and run strategy
 make fetch-strategy \
@@ -193,10 +192,10 @@ make bench-series
 
 # 5. Build a strategy and test it
 make build-strategy STRATEGY=strategies/test-simple.pine OUTPUT=test-runner
-./golang-port/build/test-runner \
+./build/test-runner \
   -symbol BTCUSDT \
   -timeframe 1h \
-  -data golang-port/testdata/ohlcv/BTCUSDT_1h.json \
+  -data tests/fixtures/ohlcv/BTCUSDT_1h.json \
   -output out/test-result.json
 
 # 6. View results
@@ -216,23 +215,18 @@ make ci
 
 ```bash
 # Verbose test output
-cd golang-port
 go test -v ./tests/integration/
 
 # Test specific function
-cd golang-port
 go test -v ./tests/integration -run TestSecurity
 
 # Check for race conditions
-cd golang-port
 go test -race -count=10 ./...
 
 # Benchmark specific package
-cd golang-port
 go test -bench=. -benchmem -benchtime=5s ./runtime/series/
 
 # Memory profiling
-cd golang-port
 go test -memprofile=mem.prof -bench=. ./runtime/series/
 go tool pprof mem.prof
 ```

ast/nodes.go

@@ -15,20 +15,26 @@ const (
 	TypeProperty                NodeType = "Property"
 	TypeBinaryExpression        NodeType = "BinaryExpression"
 	TypeIfStatement             NodeType = "IfStatement"
+	TypeForStatement            NodeType = "ForStatement"
+	TypeForInStatement          NodeType = "ForInStatement"
+	TypeWhileStatement          NodeType = "WhileStatement"
 	TypeConditionalExpression   NodeType = "ConditionalExpression"
 	TypeLogicalExpression       NodeType = "LogicalExpression"
 	TypeUnaryExpression         NodeType = "UnaryExpression"
 	TypeArrayPattern            NodeType = "ArrayPattern"
 	TypeArrowFunctionExpression NodeType = "ArrowFunctionExpression"
+	TypeBreakStatement          NodeType = "BreakStatement"
+	TypeContinueStatement       NodeType = "ContinueStatement"
 )
 
 type Node interface {
 	Type() NodeType
 }
 
 type Program struct {
-	NodeType NodeType `json:"type"`
-	Body     []Node   `json:"body"`
+	NodeType    NodeType `json:"type"`
+	Body        []Node   `json:"body"`
+	PineVersion int      `json:"pineVersion,omitempty"`
 }
 
 func (p *Program) Type() NodeType { return TypeProgram }
@@ -58,6 +64,7 @@ type VariableDeclaration struct {
 	NodeType     NodeType             `json:"type"`
 	Declarations []VariableDeclarator `json:"declarations"`
 	Kind         string               `json:"kind"`
+	Persistence  string               `json:"persistence,omitempty"` // "", "var", "varip"
 }
 
 func (v *VariableDeclaration) Type() NodeType { return TypeVariableDeclaration }
@@ -149,7 +156,40 @@ type IfStatement struct {
 	Alternate  []Node     `json:"alternate,omitempty"`
 }
 
-func (i *IfStatement) Type() NodeType { return TypeIfStatement }
+func (i *IfStatement) Type() NodeType  { return TypeIfStatement }
+func (i *IfStatement) expressionNode() {}
+
+type ForStatement struct {
+	NodeType NodeType   `json:"type"`
+	Counter  string     `json:"counter"`
+	From     Expression `json:"from"`
+	To       Expression `json:"to"`
+	Step     Expression `json:"step,omitempty"`
+	Body     []Node     `json:"body"`
+}
+
+func (f *ForStatement) Type() NodeType  { return TypeForStatement }
+func (f *ForStatement) expressionNode() {}
+
+type ForInStatement struct {
+	NodeType   NodeType   `json:"type"`
+	IndexVar   string     `json:"indexVar,omitempty"`
+	ElementVar string     `json:"elementVar"`
+	Collection Expression `json:"collection"`
+	Body       []Node     `json:"body"`
+}
+
+func (f *ForInStatement) Type() NodeType  { return TypeForInStatement }
+func (f *ForInStatement) expressionNode() {}
+
+type WhileStatement struct {
+	NodeType  NodeType   `json:"type"`
+	Condition Expression `json:"condition"`
+	Body      []Node     `json:"body"`
+}
+
+func (w *WhileStatement) Type() NodeType  { return TypeWhileStatement }
+func (w *WhileStatement) expressionNode() {}
 
 type ConditionalExpression struct {
 	NodeType   NodeType   `json:"type"`
@@ -189,3 +229,15 @@ type ArrowFunctionExpression struct {
 
 func (a *ArrowFunctionExpression) Type() NodeType  { return TypeArrowFunctionExpression }
 func (a *ArrowFunctionExpression) expressionNode() {}
+
+type BreakStatement struct {
+	NodeType NodeType `json:"type"`
+}
+
+func (b *BreakStatement) Type() NodeType { return TypeBreakStatement }
+
+type ContinueStatement struct {
+	NodeType NodeType `json:"type"`
+}
+
+func (c *ContinueStatement) Type() NodeType { return TypeContinueStatement }