clang-format #213
Open
clang-format #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quic-kdybcio
force-pushed
the
topic/clang-format
branch
from
4cb2034 to
a8855a4
Compare
quic-kdybcio
force-pushed
the
topic/clang-format
branch
from
a8855a4 to
b817eff
Compare
Author
|
On projects using GNU make, it's commonplace to add a |
quic-kdybcio
force-pushed
the
topic/clang-format
branch
from
b817eff to
2c105e0
Compare
Author
|
Pushed a change to remove spaces before braces (which we clearly don't want) |
Contributor
|
Please resolve merge conflicts |
quic-kdybcio
force-pushed
the
topic/clang-format
branch
2 times, most recently
from
3561344 to
3144455
Compare
|
This pull request has been marked as stale due to 60 days of inactivity. |
Formatting tools help maintain style consistency across the codebase. Add a config for the de-facto standard formatter, clang-format. Loosely based on the kernel code style Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Loosely based on qualcomm#136 Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
quic-kdybcio
force-pushed
the
topic/clang-format
branch
from
3144455 to
fbe72bd
Compare
Author
|
I updated a couple more bits around line wrapping and spaces around conditionals to better match the Linux style. Please take a look at the result (last commit) and check if you see anything obviously out of style |
quic-kdybcio
force-pushed
the
topic/clang-format
branch
from
fbe72bd to
8099128
Compare
Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
quic-kdybcio
force-pushed
the
topic/clang-format
branch
from
8099128 to
ae6cfc2
Compare
Author
|
Forcepushed with missing DCO fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loosely based on & supersedes #136
The config file generally resembles the code style one would expect in the kernel source tree
The last commit is a result of manually running the command that the build workflow executes and can be verified independently, the clang-format version I ran is precisely
Ubuntu clang-format version 20.1.8 (++20250804090239+87f0227cb601-1~exp1~20250804210352.139)