Update YAMLMapParser.py shebang to an external-user-friendly path #714
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We probably shouldn't be exposing internal paths and this isn't meaningful for external users. Just use the python3 found in the env as that seems closest to what is done in other scripts. I think this should be safe as it looks like most tests don't invoke the parser this way. If there are any issues exposed by using a non-3.4 version of Python, I'm also assuming those should be treated as bugs given 3.4 has been end of life for a number of years at this point. Signed-off-by: Jonathon Penix <jpenix@quicinc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We probably shouldn't be exposing internal paths and this isn't meaningful for external users. Just use the python3 found in the env as that seems closest to what is done in other scripts.
I think this should be safe as it looks like most tests don't invoke the parser this way. If there are any issues exposed by using a non-3.4 version of Python, I'm also assuming those should be treated as bugs given 3.4 has been end of life for a number of years at this point.