Conversation
|
|
||
| @Override | ||
| public boolean areContentsTheSame(@NonNull T oldItem, @NonNull T newItem) { | ||
| return false; |
There was a problem hiding this comment.
В этом методе нужно сравнить содержимое двух объектов с помощью функции equals, которая определена в интерфейсе ListDiffInterface
Owner
Author
There was a problem hiding this comment.
Залил коммит с изменениями
|
|
||
| public interface ListDiffInterface<T> { | ||
| boolean theSameAs(T t); | ||
| boolean equals(Object object); |
There was a problem hiding this comment.
Чтобы явно было видно, что это именно переопределение функции класса Object, лучше дописать к этой функции аннотацию @Overrides
Owner
Author
There was a problem hiding this comment.
Залил коммит с исправлениями в ПР
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Перед созданием ПРа проверил работоспособность фильтров приложения