reduce :pedantic? to :warn if :abort is specified. #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason: when checking if a dependency would suit an existing project (e.g. my project has a map of data somewhere and I want to serialize that data to JSON but want to try out different library) dependency conflicts will prevent the REPL from starting if `pedantic?` is set to `:abort`. The user should be able to add the dependency, try it out and handle any such conflicts at a later point in time which is why this commit will reduce the `:pedantic?` level to `:warn` if it is `:abort`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason: when checking if a dependency would suit an existing project (e.g. my project has a map of data somewhere and I want to serialize that data to JSON but want to try out different libraries) dependency conflicts will prevent the REPL from starting if
pedantic?is set to:abort.The user should be able to add the dependency, try it out and handle any such conflicts at a later point in time which is why this PR will reduce the
:pedantic?level to:warnif it is:abort.