Open
Conversation
AungKoKoLin1997
force-pushed
the
16.0-add-product_odoo_module
branch
2 times, most recently
from
b12fec1 to
a903fbd
Compare
yostashiro
reviewed
May 28, 2024
Comment on lines
10
to
12
| technical_name = fields.Char( | ||
| related="product_tmpl_id.technical_name", store=True, readonly=False | ||
| ) |
Member
There was a problem hiding this comment.
Suggested change
| technical_name = fields.Char( | |
| related="product_tmpl_id.technical_name", store=True, readonly=False | |
| ) |
Why duplicate the field from product.template when product.product already inherits product.template?
Comment on lines
+12
to
+15
| license_type = fields.Selection( | ||
| [("agpl-3", "AGPL-3"), ("lgpl-3", "LGPL-3"), ("other", "Other proprietary")], | ||
| help="Select the type of license", | ||
| ) |
Member
There was a problem hiding this comment.
Should we have this field in product.template?
yostashiro
force-pushed
the
16.0-add-product_odoo_module
branch
from
8413375 to
5e9370b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
4579