[5938][12.0][IMP] sale_order_value_proposal_by_partner_shipping: rename warehouse…#242
Merged
[5938][12.0][IMP] sale_order_value_proposal_by_partner_shipping: rename warehouse…#242
Conversation
…_id field to sale_warehouse_id
nobuQuartile
approved these changes
Jan 27, 2026
nobuQuartile
left a comment
nobuQuartile
left a comment
There was a problem hiding this comment.
Code review and functional review: LGTM
What I've checked
- I’ve applied the change to Staging and updated the module.
- The field still had the old value before the update and the translation is correct.
- When creating a Sales Order with the client, the warehouse is updated correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
5938