[6178][MIG] account_billing_dispatch_option: Migration to 18.0

[AungKoKoLin1997]

6178

[nobuQuartile]

@AungKoKoLin1997
Is the module name correct?
account_billing is like the OCA billing module.
account_move_dispatch_option is easy for me to understand.
What do you think about this point?

[AungKoKoLin1997]

@AungKoKoLin1997 Is the module name correct? account_billing is like the OCA billing module. account_move_dispatch_option is easy for me to understand. What do you think about this point?

@nobuQuartile It doesn't matter for using account_billing since it can be used in anywhere if the content is related to that.
I think account_billing_dispatch_option is valid since this module is to determine for sending the bill to the customer.
Btw, this module name is suggested by yoshi.

[nobuQuartile]

@AungKoKoLin1997 Is the module name correct? account_billing is like the OCA billing module. account_move_dispatch_option is easy for me to understand. What do you think about this point?

@nobuQuartile It doesn't matter for using account_billing since it can be used in anywhere if the content is related to that. I think account_billing_dispatch_option is valid since this module is to determine for sending the bill to the customer. Btw, this module name is suggested by yoshi.

I have checked the related ticket communication.
I believe Yoshi means that this module should include account_billing's dispatch_option because they will start using the billing module.

@yostashiro
Is this correct?

[AungKoKoLin1997]

I believe Yoshi means that this module should include account_billing's dispatch_option because they will start using the billing module.

Seem legit to me. I checked and found there is account_billing PR.
@yostashiro If it is like that, do we need this feature only in billing or both customer invoice and customer billing?

[AungKoKoLin1997]

@nobuQuartile I updated the logic. You can continue your review.

[nobuQuartile]

LGTM
Functional review and code review

[AungKoKoLin1997]

@nobuQuartile Please remove your latest commit. We don't use setup anymore.
So, I have to work on that after account_billing is merged.

[nobuQuartile]

@nobuQuartile Please remove your latest commit. We don't use setup anymore. So, I have to work on that after account_billing is merged.

OK

[yostashiro]

LGTM.