Port 16638 fix default mapping for GitHub ocean #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dennis Bilson <dennis@teksol.com.gh>
Signed-off-by: Dennis Bilson <dennis.bilson@port.io>
Signed-off-by: Dennis Bilson <dennis@teksol.com.gh>
- Added dedicated GraphQL query LIST_ORG_MEMBER_WITH_BOTS_GQL for fetching org members including bots - Simplified user filtering by using specific query based on include_bots flag instead of post-filtering - Added alias "includeBots" for the include_bots field in GithubUserSelector - Improved email filtering logic to properly handle bot accounts - Removed redundant type checking since bot filtering is now handled at query level Signed-off-by: Dennis Bilson <dennis.bilson@port.io>
- Rewrote sanitize_login function to better handle consecutive brackets and edge cases - Split bracket replacement into distinct steps for clearer logic: 1. Replace consecutive ][ with single dash 2. Replace remaining [ with dash 3. Replace ] with dash except when at end of string - Uncommented and updated test cases to verify correct handling of various login formats - Removed edge cases from test suite that were no longer neede
- Eliminated unnecessary `include_bots` condition when filtering users without email. - Updated test case to include an email field for validation.
…ings - Updated gsub patterns for creator, assignees, and reviewers to fix inconsistencies in bracket sanitization.
quabynah-bilson
requested review from
Ak-Euph,
bella-shapaz and
reinetteallotey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What -
Why -
How -
Type of change
Please leave one option from the following and delete the rest:
All tests should be run against the port production environment(using a testing org).
Core testing checklist
Integration testing checklist
examplesfolder in the integration directory.Preflight checklist
Screenshots
Include screenshots from your environment showing how the resources of the integration will look.
API Documentation
Provide links to the API documentation used for this integration.