[825] Incorrect disk space calculation inside docker container #828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archeoss
changed the title
Member
|
Please, do not forget to fix space calculation from results of |
ikopylov
reviewed
Jan 26, 2024
bob/src/hw_metrics_collector.rs
Outdated
| if dev_path | ||
| .iter() | ||
| .filter(|(dev, _)| *dev == metadata.dev()) | ||
| .any(|(_, path)| disk.mount_point().file_name() == path.file_name()) |
Member
There was a problem hiding this comment.
This is not correct. We should check that disk.mount_point() is a prefix of path. Example: mount_point = "/opt/disk1/", path = "/opt/disk1/bob". Use starts_with function
ikopylov
reviewed
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #825
Note 1: usage of frsize instead of bsize seems to do nothing (at least on Linux). Needs to be tested on some Mac machine, where it's first occured. Also this change about frsize needs to be done after #823 will be merged, since that function was rewritten there