Skip to content

Conversation

@tomerqodo
Copy link

Benchmark PR langgenius#29224

Type: Clean (correct implementation)

Original PR Title: chore(web): run oxlint before eslint
Original PR Description: [!IMPORTANT]

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #29223.

Fixes langgenius#29223

Summary

  • add oxlint CLI and lint:oxlint script so oxlint always runs before eslint in web lint commands
  • wire oxlint into husky pre-commit to guard staged web changes, and fix lint warnings surfaced by oxlint
  • note: running full eslint reveals pre-existing warnings/errors outside this change; not addressed in this PR

Screenshots

Before After
N/A N/A

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
    Original PR URL: chore(web): run oxlint before eslint langgenius/dify#29224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants