Add StateMachine.StateWithArgs#102
Merged
qmuntal merged 2 commits intoqmuntal:masterfrom Feb 10, 2026
Merged
Conversation
Contributor
sergiogbr
commented
Feb 6, 2026
sergiogbr
commented
- Add comprehensive documentation for StateWithArgs method explaining its purpose and use case
- Add 4 unit tests covering different scenarios:
- Basic usage with NewStateMachine
- Usage with NewStateMachineWithExternalStorage
- Full functionality with NewStateMachineWithExternalStorageAndArgs
- Error handling when state accessor fails
- All tests follow existing test patterns and pass successfully
- Add comprehensive documentation for StateWithArgs method explaining its purpose and use case - Add 4 unit tests covering different scenarios: * Basic usage with NewStateMachine * Usage with NewStateMachineWithExternalStorage * Full functionality with NewStateMachineWithExternalStorageAndArgs * Error handling when state accessor fails - All tests follow existing test patterns and pass successfully
There was a problem hiding this comment.
Pull request overview
This PR adds the StateWithArgs method to the StateMachine API, which exposes both the current state and any arguments that were passed to the state mutator. This is particularly useful when using NewStateMachineWithExternalStorageAndArgs to retain additional state information alongside the state itself.
Changes:
- Added
StateWithArgsmethod to StateMachine with documentation explaining its purpose - Added 4 comprehensive unit tests covering different state machine initialization patterns and error handling
- All tests follow existing naming conventions and test patterns
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| statemachine.go | Adds the StateWithArgs method with clear documentation explaining when it's useful (primarily with NewStateMachineWithExternalStorageAndArgs) |
| statemachine_test.go | Adds 4 unit tests covering StateWithArgs with NewStateMachine, NewStateMachineWithExternalStorage, NewStateMachineWithExternalStorageAndArgs, and error handling scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
PR looks good, thanks! CI is broken on master too, will fix that myself. |
qmuntal
changed the title
Owner
|
Needs rebasing, sorry |
Contributor
Author
|
done :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.