This repository was archived by the owner on Jul 9, 2024. It is now read-only.
Added hindi Language to string.yml!#65
Open
sakkshm wants to merge 1 commit intoqmk:gh-pagesfrom
sakkshm:patch-1
Open
Added hindi Language to string.yml!#65sakkshm wants to merge 1 commit intoqmk:gh-pagesfrom sakkshm:patch-1
sakkshm wants to merge 1 commit intoqmk:gh-pagesfrom
sakkshm:patch-1
Conversation
sagarvd01
reviewed
Oct 24, 2019
Contributor
sagarvd01
left a comment
sagarvd01
left a comment
There was a problem hiding this comment.
On line 24, is it कीबोर्ड्स or कीबोर्ड?
noroadsleft
suggested changes
Oct 28, 2019
Member
There was a problem hiding this comment.
This adds Hindi as an option, but doesn't translate any of the pages, so the Hindi option would still serve English pages.
At minimum, I'd like to see translations of:
- https://github.com/qmk/qmk.fm/blob/gh-pages/_i18n/en/index.md
- https://github.com/qmk/qmk.fm/blob/gh-pages/_i18n/en/changes.md
- https://github.com/qmk/qmk.fm/blob/gh-pages/_i18n/en/sidebar.md
for this PR to be accepted.
| made_possible: "Dieses Projekt wird von den <a href='https://github.com/qmk'>QMK-Entwicklern</a> und Mitwirkenden wie Ihnen unterstützt!" | ||
| hosted_on: "Betrieben mit GitHub Pages — Layout von <a href='https://github.com/orderedlist'>orderedlist</a>" | ||
| description: "Eine Open Source Firmware für auf AVR oder ARM basierende Tastaturen" | ||
| hi: &DEFAULT_HI |
Member
There was a problem hiding this comment.
Can you fix the indent here?
Suggested change
| hi: &DEFAULT_HI | |
| hi: &DEFAULT_HI |
noroadsleft
added
the
awaiting changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.