This repository was archived by the owner on Jul 9, 2024. It is now read-only.
Open
Conversation
added 5 commits
June 21, 2019 21:18
* Align top plate margins * Align standoff cutouts In the previous iteration we had both the switch cutouts and the standoff cutouts "leaning" to the left, making the print look uneven. Also, the standoff cutouts from the top didn't match the ones from the bottom. See screenshots on https://github.com/qmk/qmk.fm/issues/50
* There was a hole that didn't match the design of the PCB. That has been removed now. * The screw holes were not really centered with the actual PCB. This commit also aligns that.
Author
|
Hey @jackhumbert any chance to take a look at this PR? Quite straight forward :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses some of the issues mentioned on https://github.com/qmk/qmk.fm/issues/50
Most of the issues have been addressed. The only outstanding one is number 4 from that list, which I am happy to work on given some guidance on it.